[Freeciv-Dev] Re: [Patch] Add BOOL_VAL around ANDs

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> 
> The attached patch adds BOOL_VAL() around expressions of the form "x &
> S_*". This is required since the result is used as a boolean but isn't
> one.

I am confused about use of special field in tile.
It is declared as enum tile_special_type, but used as an int:
=========================
1207 void map_set_special(int x, int y, enum tile_special_type spe)
1208 {
1209   MAP_TILE(x, y)->special |= spe;
1210 
1211   if (spe & (S_ROAD | S_RAILROAD))
1212     reset_move_costs(x, y);
1213 }
=========================
Doesn't your Spliff complain about it?


As for the patch, you might as well make a function
bool contains_special(int tspecials, enum tile_special_type special)
or even
bool tile_has_special(struct *tile ptile, enum tile_special_type special)

But then who cares...

Best,
G.



__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com