[Freeciv-Dev] Re: [Patch] Add BOOL_VAL around ANDs

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Tue, Feb 12, 2002 at 01:37:10PM +0100, Petr Baudis wrote:
[...]
> > Hmm, I would like tile_has_special() much more that BOOL_VAL(..). It
> fixes the
> > boolean issue _and_ raises the level of encapsulation, which is good.
> 
> I have no problem introducing contains_special. Petr, Gregory?

What Gregory?
You know my opinion: if you are doing BOOL_VAL, than do it properly in a
function/macro.

As for the patch which is already in, well, if you are looking for
people's opinions maybe you should give us a reasonable time to react. 
And if you are not, then you might as well put your patch straight in
without bothering to mail it to the list.  Just like Vasc does it.  Which
annoys me even more than your formal "submitting a patch".

But then you are maintainers, you are gods, so what the hell.

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com