[Freeciv-Dev] Re: Improved game starting version 6 [patch] [ready, IMO] (PR#1215)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Jan 14, 2002 at 12:50:21AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> >>The interface looks very good; I think its time to seriously consider 
> >>applying this.  But you need to fix the diff problem, of course.  (Why 
> >>does nobody use "cvs diff" around here?)
> > 
> > How and why does one use "cvs diff"?
> 
>  From within a directory maintained by cvs, just run "cvs diff".  If you 
> need help setting up CVS, see the "how to contribute" (IIRC) link off of 
> www.freeciv.org.
> 
> Why: because it's very very easy.  One line will make all the patch you 
> need; you don't need to worry about tracking a separate directory or 
> copy of the file at all.

Ack. I usually only have one tree. Very easy. Back them out with 
"cvs diff -u >diff;patch -p0 -R <diff".

> The only disadvantage is it uses the network and so may be slow for some.

And you can't get diffs for added files.

> >>- A lot of the spacing doesn't follow the style guide.  The #includes 
> >>also aren't grouped correctly in some cases.  Blah, blah, blah...
> >>
> >>
> > 
> > I haven't really followed the style thread (I've always found that
> > formatting of that type has almost no effect on readability), but my
> > impression was that the guide wasn't completed.  If it is, I suppose I'll
> > go through and bring this into compliance.
> 
> k&r style has been the style; recent threads have only refined this. 

> The style guide was (I think) placed into CVS today.

Yes the first part is now in CVS.

> Some people (Raimar?) have a script that they run over patches (?) to 
> indent them.  This would probably be of use to (just about) everyone. 
> It should be made public or even put into CVS.

http://arch.freeciv.org/freeciv-dev-200108/msg00486.html

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Windows is the one true OS. MS invented the GUI. MS invented 
   the 32 bit OS. MS is open and standard. MS loves you. We have 
   always been at war with Oceana."