[Freeciv-Dev] Re: PATCH: AI cleanup Version 2

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Nov 24, 2001 at 06:00:41AM -0800, Raahul Kumar wrote:
> 
> --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > On Fri, Nov 23, 2001 at 09:08:22PM -0800, Raahul Kumar wrote:
> > > 
> > > --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > 
> > > Do you have any problems with the current patch I sent your way? If so,
> > > I would appreciate comments.
> > 
> > To be honest I'm a bit lost. Suddenly three people work on the ai
> > movement code and produce patches like there is no tomorrow (which is
> > good). How does all the patches relate to each other?
> > 
> > The changes in aicleanupv2.diff are ok.
> > 
> 
> Thanks. Can you apply them soon?

My backlog is quite long. I'm currently on 990 and 1043. So it is more
"a submit it, draw a number and wait".

> My code stands on its own as a
> unit.  You can apply it without worries as to the effect on the
> other movement code people. In fact, Petr's assumes my patch has
> been applied.
> 
> I'd like to hold off sending the 3rd patch in the series until
> you've either applied v1 & 2 or asked me to amend them.
> 
> What is currently happening is a general cleanup of the server ai,
> focusing exclusively on the movement code ( including an igter unit
> fix, but that depends on what GB says).
> 
> I also had a go at renemaing the variable names of the
> find_something_to kill and other ai funcs from a,b,c,d,e,f etc to
> more descriptive names. That is where Petr comes in. I asked about
> better names, and an explanation of what those funcs did. Petr
> chipped in with comments I believe are correct(so far I've found no
> holes in his logic).
> 

> I believe Petr understands those ai functions. 

It looks you together can decipher them which is good.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I heard if you play the NT-4.0-CD backwards, you get a satanic message."
 "That's nothing, if you play it forward, it installs NT-4.0"