Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: PATCH: AI cleanup Version 2
Home

[Freeciv-Dev] Re: PATCH: AI cleanup Version 2

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Petr Baudis <pasky@xxxxxxxxxxx>, rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: Raahul Kumar <raahul_da_man@xxxxxxxxx>, Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: PATCH: AI cleanup Version 2
From: Raahul Kumar <raahul_da_man@xxxxxxxxx>
Date: Sat, 24 Nov 2001 06:14:56 -0800 (PST)

--- Petr Baudis <pasky@xxxxxxxxxxx> wrote:
> > To be honest I'm a bit lost. Suddenly three people work on the ai
> > movement code and produce patches like there is no tomorrow (which is
> > good). How does all the patches relate to each other?
> My patch applies on the top of Raahul's one. It corrects indendation
> of one function he changed, as it is broken, and does more cleanups and
> adds some comments.
> 
> I attach hopefully the final version of it ;-). I added some comments,
> removed some indendation changes and made even more variables local.
 
Petr, I do not like the way you reformatted unit_move_turns for no apparent
reason. Ordinarily I don't care about formatting changes like Raimar does.
I won't complain if you reformat and improve readibility. But that reformat
adds nothing. Delete those lines from the patch.

__________________________________________________
Do You Yahoo!?
Yahoo! GeoCities - quick and easy web site hosting, just $8.95/month.
http://geocities.yahoo.com/ps/info1


[Prev in Thread] Current Thread [Next in Thread]