[Freeciv-Dev] Re: new_city_dialog ver 12

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-10-24 18:44:32, Raimar Falke wrote:
> On Wed, Oct 24, 2001 at 05:49:17PM +0200, Daniel Sjölie wrote:
> > On 2001-10-24 17:08:08, Raimar Falke wrote:
> > > > > There is still some resizing if the city is changed. It looks like
> > > > > this is caused by the improvement list.
> > > > 
> > > > Well, it rezises because it needs more room, right? I think that's ok...
> > > > Would you have it always at max size?
> > > 
> > > I just checked this: to size of the windows does change. I have no
> > > preference how you solve this problem.
> > 
> > Well, my point was that I don't think that there is a good solution...
> 
> Completely untested:
> 
> void popup_city_dialog(struct city *pcity, int make_modal)
> {
>   struct city_dialog *pdialog;
> 
>   if (!(pdialog = get_city_dialog(pcity))) {
>     pdialog = create_city_dialog(pcity, make_modal);
>   }
>   gtk_set_relative_position(toplevel, pdialog->shell, 10, 10);
> 
>   gtk_widget_show(pdialog->shell);
> + gdk_window_raise(pdialog->shel->window);
> }

Well, that seems to work fine (with the misspelling fixed ;) but this
was not what I was talking about here... The problem I think lacks a
good solution is when the dialog is resized when more space is needed in
the improvements list... I think neither setting it to max size from the
start (might not be trivial to do right) or disallowing resizing is good
solutions...

The patch above will be included though...

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)