[Freeciv-Dev] Re: [Patch] New city dialog - new patch

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-08-30 17:36:20, Raimar Falke wrote:
> On Thu, Aug 30, 2001 at 05:13:25PM +0200, Christian Knoke wrote:
> > Am Donnerstag, 30. August 2001 12:30 schrieb Daniel Sjölie:
> > >
> > > Patch:
> > > http://www.acc.umu.se/~deepone/freeciv/new_city_dialog3.diff.gz
> > >
> > > Comments still very welcome...
> > 
> > Ok, here is some feedback (promising more):
> > 
> > First, it's getting better!
> > 
> > It's not too big any more.
> > 
> > What about changing the traderoute display?
> > You now have:
> > 
> > ---------------------------------
> > Esthablished trade routes
> > City names     |   Trade/Year
> > There are no traderoutes
> > . . .
> > . . .
> > ---------------------------------
> > 
> > Display only a non-structured area (white?)
> > like this:
> > 
> > --------------------------------------
> > Traderoute to Berlin gives 1 trade(s)
> > Traderoute to Bonn gives 3 trade(s)
> > ---------------------------------------
> > 
> > thus reflecting that the user can't change it
> > in the dialog, plus it's using less space.
> > simpler=clearer

Yes, I like this...

> > exchange "close dialog" and "next city" button. Make them
> > different/smaller.
> 
> Ack. I always click the leftmost button to close the window.

I thought it looked kind of nice in the middle... :) But since there's
two of You I'll comply... :)

> > within the present units area, the '>' works wrong
> > (should be disabled with 1 unit, but isn't)
> 
> Ack.

I'll check it...

> > Next / Prev city: In which order are the cities presented?
> > I suggest alphabetical order, or island for island, and alphabetical
> > subordered.
> 
> AFAIK in no particular.

I'll consider that an issue for further work after the dialog has been
commited...

> > How is the senty/fortify button supposed to work? For me,
> > it sentries a fortified musketeer, but never fortifies it.
> > 
> > In the worklist area, there should be an append button.
> > It is not obviously, that insert works different, when
> > no entry is marked.
> > 
> > I have to test the worklist thing, it seems not working
> > correct.
> > 
> > In the worklist, the right help button doesn't work.
> > Maybe the reason is long text in german locale (not tested).
> 
> This is the reason. What should happen here?

I'm compiling with --disable-nls so someone else should ponder this
one...

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)