[Freeciv-Dev] Re: patches

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Aug 22, 2001 at 10:45:48AM +0200, Raimar Falke wrote:
> 

An updated version:

 0: likely to be applied soon
 1 and 2: I like the idea and the patch
 1: only minor demurs
 2: there is a/are some objection(s) or I haven't took a deep look at it
 3: there are design issues still open or major objections or I still
    have to be convinced that the performance will be improved
 ?: I don't know
 Q: in my queue for review/rework

Patches:
 - new city dialog (Q)
 - popcost by Arien (Q)
 - other cleanup patches by Ross (Q)

 - slight optimisation at client/packhand.c from Markus (1)

 - watchtower by Bert(2)
 - other directional cleanups by Jason (2)
 - Small improvement at genlist and maphand by Markus (2)

 - Sound by David (3)
 - tilecache by Kevin (3)
 - freeing NULL ptrs from Justin (3)
 - Password authentication from Auth (3)
 - different monetary units by Baumans (3)
 - sortlist by Justin (3)

 - GUI-specific options by Kevin (?)
 - scorelog patch(es) by Justin (?)
 - incorrect production with Hanging Gardens by Patrick (?)

Ideas:
 - extended units statistics
 - settler activity progress
 - extend style guide
   * init vars
       int foo(struct city *punit){int x=punit->x;} or
       int foo(struct city *punit){int x; x=punit->x;}
   * empty line after vars
       int x;\nx=3; or
       int x;\n\nx=3;
   * comments
       x=3; /* assign 3 to x */ or
       /* assign 3 to x */
       x=3;
   * extra {} on iterates
 - move functions comment to header file?

TODO:
 - ffs
 - fast continent iteration (or at least an abstraction)
 - any patch which replaces ids with pointers
 - MAPSTEP as a separate patch
 - id to pointers in structs (low priority)
 - vision range
 - new method is_city_center
 - cartesian_adjacent_iterate (move normalize_map_pos out of switch
   statement)
 - s/best=SOME_VALUE/best=SOME_UNUSED_VALUE/
 - get_grid_color and normalized coord (BUG)
 - struct splitting in client and server
 - trieme loss==0

My patches:
 - Introduction of turns
 - sprite stuff
 - auto connect

Anything forgotten? I would be happy if someone tackle a problem from
the todo list.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Tank: So what do you need? Besides a miracle.
  Neo: Guns. Lots of guns.
    -- From The Matrix