[Freeciv-Dev] Re: [PATCH] bugfix for wrapping problem

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

You are changing the current behaviour. 

If this is a bugfix, get someone knowledgable to validate it.

If this is being done as an "improvement", in my view it is not.

Your arguments about robustness are valid only in the larger
context of what *should* it be doing which has not been determined.
Wanting to draw multiple images of the same tile is not the same
as there is a real and valid reason to draw multiple images of 
the same tile. In my view this would lead to gaming anarchy and
should be explicitly and irrevocably disallowed. 
 
It is "robust" now in that it doesn't fault. And you should work 
out the larger GUI design context before making one-off changes
to fix something that isn't broken.

In either case, so far no one has convinced me they have the 
background, understanding or have adequately investigated the 
ramifications of this to be credibale on this area.

Act in haste, repent at leisure is not always the best course of 
action :-).

Cheers,
RossW
=====

At 09:30 PM 01/08/24 +0200, Raimar Falke wrote:
>On Fri, Aug 24, 2001 at 03:18:48PM -0400, Ross W. Wetmore wrote:
>> Are there any GUI experts around?
>> 
>> IMHO, having the same position drawn more than once is an error. If
>> you stretch the canvas to exceed the base map size, I'm not sure
>> that seeing only a single valued map isn't the desired behaviour. If 
>> there is a vote, I would vote for this, and not the other.
>
>For robustness and also as somebody will want this we should support
>this (drawing the same map position multiple times on the screen).
>
>> Resize, if ever implemented, may make the argument mute though.
>> 
>> I think the patch should NOT be applied until this is worked out.
>
>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
>  Two OS engineers facing a petri net chart:
>        "dead lock in four moves!"