[Freeciv-Dev] Re: [PATCH] bugfix for wrapping problem

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Aug 24, 2001 at 03:32:43AM -0400, Jason Dorje Short wrote:
> I was right - the normalizations Ross was replacing that didn't check
> the return value were being used incorrectly.  The map positions were
> being normalized too early, so that it was the normalized coordinates
> rather than the absolute ones that were being used to draw to the
> canvas.  A screenshot of the current behavior was sent a little while
> ago, but I can't find it now.
> 
> The attached patch fixes this in a very simple manner.  It's intended as
> a preliminary patch just to reveal the problem - it only fixes things
> for the standard (non-orthogonal) tiles, only for GTK, and doesn't fix
> things like city names (which will be harder).
> 
> To see it in action, start up a game using a small tileset and make your
> client window very large.  The graphics will not wrap around; you'll
> never see the same spot of land twice.  Now apply the patch, recompile,
> and restart the client.  Things will work!

So we need another type of positions in the client gui? Since I like
"map pos(ition)" for the general (almost always normalized)
position. What about "canvas position"? This is just so that nobody
will get misunderstood.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python is executable pseudocode. Perl is executable line noise"
    -- Bruce Eckel