[Freeciv-Dev] Re: [PATCH] bugfix for wrapping problem

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Aug 24, 2001 at 04:32:26AM -0400, Jason Dorje Short wrote:
> Raimar Falke wrote:
> > 
> 
> > So we need another type of positions in the client gui? Since I like
> > "map pos(ition)" for the general (almost always normalized)
> > position. What about "canvas position"? This is just so that nobody
> > will get misunderstood.
> 
> Canvas position is no good because canvas_x and canvas_y are used for
> drawing positions (pixels).

Ok.

> If any new nomenclature is needed, it should be "absolute".  In my
> patch, I've used this as a naming convention, i.e. abs_x versus map_x.

Ok with me.

> The attached patch should be in a usable form.  It fixes the wrapping
> problem for drawing cities as well - the error was identical.  It
> doesn't touch isometric view code, and only fixes GTK.  I don't see any
> reason not apply it :-)

I like to first get some comments from other people.

> There's still a small bug: when updating units received from the server
> the client will only move them in one position, leaving the other tile
> of the unit in place.  When the client next does a redraw (soon after)
> they'll get updated.  This should only be a problem for people using a
> super-wide window.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Only one human captain has ever survived battle with the Minbari
  fleet. He is behind me. You are in front of me. If you value your 
  lives, be somewhere else."
    -- Ambassador Delenn, "Severed Dreams," Babylon 5