[Freeciv-Dev] cityname patch
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Well i've had a really hard time with this patch. The Lisp parser is
particularly obscure. I haven't even understood what grammar it's
parsing! :-)
From the author's comments i guess he didn't mean it to be used for
purposes other than XConq so i guess we'll have to do this in a different
way.
I tried cleaning up the code a bit (well split the functions & put
some function declarations in include files instead of that hodge podge of
extern's) the (incomplete but compilable) patch is at:
<ftp://ftp.freeciv.org/freeciv/incoming/citynames-9.diff.bz2>
I'm not certain i'll continue working on it though. I think i could write
a new parser in Freeciv style faster than to hand convert this one.
IMO we should start thinking of this in a different way. I know people
have wanted scripting in Freeciv for some time so we probably should
decide what kind of language we're going to use. But i guess it's kind of
overkill to add a Lisp parser just for cityname generation.
If similar patches to this are to be accepted in the future they should
consist of the parser & necessary support *only* at the beggining. After
the parser is in place we can worry with the rest.
---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa
- [Freeciv-Dev] cityname patch, Vasco Alexandre Da Silva Costa, 2001/02/19
- [Freeciv-Dev] cityname patch,
Vasco Alexandre Da Silva Costa <=
- [Freeciv-Dev] Re: cityname patch, Stan Shebs, 2001/02/22
- [Freeciv-Dev] Re: cityname patch, Erik Sigra, 2001/02/24
- [Freeciv-Dev] Re: cityname patch, Vasco Alexandre Da Silva Costa, 2001/02/24
- [Freeciv-Dev] Re: cityname patch, Raimar Falke, 2001/02/24
- [Freeciv-Dev] Re: cityname patch, Erik Sigra, 2001/02/25
- [Freeciv-Dev] Re: cityname patch, Raimar Falke, 2001/02/25
- [Freeciv-Dev] Re: cityname patch, Erik Sigra, 2001/02/25
- [Freeciv-Dev] Re: cityname patch, Raimar Falke, 2001/02/25
- [Freeciv-Dev] Re: cityname patch, Erik Sigra, 2001/02/25
- [Freeciv-Dev] Re: cityname patch, Raimar Falke, 2001/02/25
|
|