[Freeciv-Dev] Re: Bug/PATCH: Fortresses can be built in cities (PR#662)

["SamBC" <sambc@xxxxxxxxxxxxxxxxxxx>]

----- Original Message -----
From: "Mike Jing" <miky40@xxxxxxxxxxx>

> Like I said, the code tells me a fortress has _no_effect_ in a city,
so it
> is a waste of time unless you want to change this behavior.
Furthermore, a
> city already enjoys a defense bonus of 1.5, and in Civ2 you can't
build
> fortresses in cities at all.  But I agree this could be an interesting
idea.
>
> BTW, fortifying inside a city has no effect either:
>
> 504 if ((defender->activity == ACTIVITY_FORTIFIED ||
> 505      map_get_city(defender->x, defender->y)) &&
> 506     is_ground_unit(defender))
> 507   defensepower*=1.5;

Isn't that the 50% bonus for being 'defensive' unit like spearmen in a
defensible position (ie fortified anywhere, or in a city)? If fortifying
in a city does nothing, then this is wrong IIRC.

SamBC