Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2000:
[Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by
Home

[Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by barbarians upon entering a hut.
From: Big Gaute <gs234@xxxxxxxxx>
Date: 04 Jul 2000 04:23:39 +0200

Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxxx> writes:

> Just one comment: this code was changed recently on CVS because it
> caused server crashes when the unit was killed (and it's struct
> free'ed).  Your patch reinstates the old behaviour (and the bug).
> Please save the unit type in some variable before the
> unleash_barbarians() call, and use that instead of the possibly
> free'ed unit struct.

Wow.  If that's not a really dumb mistake to make, I don't know what
is.  The punit_x and punit_y variables ougth to be indication enough.

Anyway, here is an updated patch:

Attachment: verbose_barbarians.diff
Description: Patch to CVS snapshot from 3 July 2000

-- 
Big Gaute (not to be confused with LG)
"There was a time when a guy who died at forty was revered as the toughest
and most doggedly ancient son of a bitch in Cow Ass Clearing, Shitoleshire,
Engalond, back in the year dot." - Spider Jerusalem, Transmetropolitan #25

[Prev in Thread] Current Thread [Next in Thread]