[Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Mon, Jul 03, 2000 at 04:41:52AM +0200, Big Gaute wrote:
>
> Currently, whenever a unit enters a hut and is killed by barbarians
> the message "Your unit has been killed by barbarians." is sent to the
> player. I changed this to explicitly tell what sort of unit was
> killed.
>
> I ran into a problem while doing this: since some unit names are
> plurals (e.g. "Settlers") it is not enough to simply use unit_name()
> as a drop-in replacement for "unit", since you would also have to
> change "has" to "have" as appropriate. In the end I rewrote the
> sentence to avoid the problem, but I am not sure which way is better.
>
> Also, unit_name() returns a capitalised name. I'm not sure if it's
> worth the bother to compensate for this.
IMHO ``Settlers'' etc. is name of unit type not unit.
Even if type is plural, there is single unit, so singular should be used.
In other words, before ``Settlers'' there is implicit ``unit of type''.
Am I very wrong ?
printf ("Your %s unit has been killed by barbarians.", unittype);
[Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by barbarians upon entering a hut., Vasco Alexandre Da Silva Costa, 2000/07/03
|
|