Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2000:
[Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by
Home

[Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] More explicit message when a unit is killed by barbarians upon entering a hut.
From: Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxxx>
Date: Tue, 4 Jul 2000 02:36:19 +0100 (WET DST)

On 3 Jul 2000, Big Gaute wrote:

> 
> Currently, whenever a unit enters a hut and is killed by barbarians
> the message "Your unit has been killed by barbarians." is sent to the
> player.  I changed this to explicitly tell what sort of unit was
> killed.

Just one comment: this code was changed recently on CVS because it caused
server crashes when the unit was killed (and it's struct free'ed).
Your patch reinstates the old behaviour (and the bug).
Please save the unit type in some variable before the
unleash_barbarians() call, and use that instead of the possibly free'ed
unit struct.

Thanks,

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa




[Prev in Thread] Current Thread [Next in Thread]