[Freeciv-Dev] Re: (PR#9818) Inland lakes and borders

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9818 >

On Mon, 30 Aug 2004, Mateusz Stefek wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9818 >
> 
> Any more objections to this patch? If no, I will commit it tommorow.

The patch seems ok.  Why did you make get_continent_size() and 
get_ocean_size() functions if you don't use them.  It's fine by me, 
compiler will kill them, but maybe others will object.  Well, at least you 
can use get_ocean_size instead of 
        ocean_sizes[-cont] <= MAXIMUM_CLAIMED_OCEAN_SIZE

Also, all these negative array indeces look ugly, maybe we can invent 
something to incapsulate the negativeness.  like get_ocean_number.
but it might cause even more ugliness...
Anyway, it's a subject for a different patch.

G.