Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] (PR#9818) Inland lakes and borders

[Freeciv-Dev] (PR#9818) Inland lakes and borders

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#9818) Inland lakes and borders
From: "Mateusz Stefek" <mstefek@xxxxxxxxx>
Date: Mon, 30 Aug 2004 14:51:48 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: >

> [glip - Mon Aug 30 21:22:13 2004]:
> On Mon, 30 Aug 2004, Mateusz Stefek wrote:
> > <URL: >
> > 
> > Any more objections to this patch? If no, I will commit it tommorow.
> The patch seems ok.  Why did you make get_continent_size() and 
> get_ocean_size() functions if you don't use them. 
Marcelo needs these functions in his patches.
> It's fine by me, 
> compiler will kill them, but maybe others will object.  Well, at least
> can use get_ocean_size instead of 
>       ocean_sizes[-cont] <= MAXIMUM_CLAIMED_OCEAN_SIZE
good point

> Also, all these negative array indeces look ugly, maybe we can invent 
> something to incapsulate the negativeness.  like get_ocean_number.
> but it might cause even more ugliness...
> Anyway, it's a subject for a different patch.
> G.
Yes. This system is bug-prone. (As seen in PR#9877). I'm going to fix it 
somehow later.
P.S. I post this answer by e-mail but it didn't get here.

[Prev in Thread] Current Thread [Next in Thread]