Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#9818) Inland lakes and borders

[Freeciv-Dev] Re: (PR#9818) Inland lakes and borders

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#9818) Inland lakes and borders
From: "Mateusz Stefek" <mstefek@xxxxxxxxx>
Date: Mon, 30 Aug 2004 15:04:37 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: >

Dnia 2004-08-30 23:22:16, Gregory Berkolaiko napisał(a):
> <URL: >
> > Any more objections to this patch? If no, I will commit it  
> tommorow.
> The patch seems ok.  Why did you make get_continent_size() and
> get_ocean_size() functions if you don't use them.

Marcelo needs these functions in his patches.

> It's fine by me,
> compiler will kill them, but maybe others will object.  Well, at  
> least
> you
> can use get_ocean_size instead of
>       ocean_sizes[-cont] <= MAXIMUM_CLAIMED_OCEAN_SIZE

good point

> Also, all these negative array indeces look ugly, maybe we can invent
> something to incapsulate the negativeness.  like get_ocean_number.
> but it might cause even more ugliness...
> Anyway, it's a subject for a different patch.
> G.
Yes. This system is bug-prone. (As seen in PR#9877). I'm going to fix  
it somehow later.

Startuj z INTERIA.PL!!! >>>

[Prev in Thread] Current Thread [Next in Thread]