[Freeciv-Dev] Re: client/server authentication (PR#1767)

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Apr 11, 2003 at 12:30:57AM -0700, Raimar Falke wrote:
> 
> Looks ok altrhough you could have done more indent cleanup if you
> touch these lines.

I did minimal cleanup because I wanted a a simple patch, and doing indent
cleanup on just the lines (for exmple in the win32 client) I touched would
have required more extensive cleanup for consistency.
 
> > auth4-5k.diff: implement _simple_ server-side authentication. 
> 
> enum authentication_type doesn't have a docu.

easily solved.
 
> > o add database.[ch] to handle a user database. currently can only create
> >   a new entry, search for an entry by username and do a search by usernamd
> >   and return the password. Note: the db_entry struct is rudimentary and
> >   most of the fields present are unused and for demonstration purposes.
> >   Our current ranking system is expected to be plugged in here somehow.
> 
> The name "database" is too general.

I don't know. we could have multiple databases here, or we culd rename it
user_database.c
 
> > o note: the database is binary. we could do this using freeciv registry,
> >   but I'm afraid this would be really slow and not really suited for 
> >   sequential search. comments welcome. tools will need to be written to 
> >   manipluate the database for administrative purposes.
> 
> The current code is bad since it isn't endian nor 64bit safe.
> 
> The freeciv registry is the way to go. If you have 100 logins/s the
> speed may matter and you would have to cache the DB in memory. But
> this isn't the case.

I think it will be the case where pubserver has a couple hundred users in
the database (you only have to log in once to get an entry after all). I'll
think about it. Writing to the database may be a problem...

-mike