[Freeciv-Dev] Re: client/server authentication (PR#1767)

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Fri, Apr 11, 2003 at 06:09:23AM -0700, Mike Kaufman wrote:
> On Fri, Apr 11, 2003 at 12:30:57AM -0700, Raimar Falke wrote:
> > > auth4-5k.diff: implement _simple_ server-side authentication. 
> > 
> > enum authentication_type doesn't have a docu.
> 
> easily solved.

It is quite possible that I have other complains when you documented
these. I don't like the idea that the client sends the password twice
to the server. The test for equality can be done at the client.

> > > o add database.[ch] to handle a user database. currently can only create
> > >   a new entry, search for an entry by username and do a search by usernamd
> > >   and return the password. Note: the db_entry struct is rudimentary and
> > >   most of the fields present are unused and for demonstration purposes.
> > >   Our current ranking system is expected to be plugged in here somehow.
> > 
> > The name "database" is too general.
> 
> I don't know. we could have multiple databases here, or we culd rename it
> user_database.c

user_database.c is ok for me.

> > > o note: the database is binary. we could do this using freeciv registry,
> > >   but I'm afraid this would be really slow and not really suited for 
> > >   sequential search. comments welcome. tools will need to be written to 
> > >   manipluate the database for administrative purposes.
> > 
> > The current code is bad since it isn't endian nor 64bit safe.
> > 
> > The freeciv registry is the way to go. If you have 100 logins/s the
> > speed may matter and you would have to cache the DB in memory. But
> > this isn't the case.
> 
> I think it will be the case where pubserver has a couple hundred users in
> the database (you only have to log in once to get an entry after all). I'll
> think about it. Writing to the database may be a problem...

For pubserver you also have to think about locking. Multiple servers
writing to it. This is independent of the format.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Living on earth may be expensive, but it includes an annual free trip
  around the sun.