[Freeciv-Dev] Re: (PR#2370) Path finding

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Mon, Mar 03, 2003 at 05:00:29AM -0800, Gregory Berkolaiko wrote:
> > > +  enum direction8 dir_to_next_pos;       /* Unsed only in struct_path */
> > 
> > It should be set to an invalid value otherwise.
> 
> Is
>       #ifdef DEBUG 
> ok with you?

This is ugly. And the write comes for free since this region is
already cached.

> > It looks like you forgot a pf_destroy_path function. I know why I
> > prefer static allocation when it is possible.
> 
> Thinking about it, we should then change the signature to
>       struct pf_path *pf_get_path(pf_map, x, y)
> and let pf_get_path do all the allocations.
> 
> Is it okay with you?

Yes.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "If at first you don't succeed... well so much for skydiving."