[Freeciv-Dev] Re: (PR#2370) Path finding

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Sun, 2 Mar 2003, Raimar Falke wrote:

> On Thu, Feb 27, 2003 at 01:51:34PM -0800, Gregory Berkolaiko wrote:
> 
> > + *      Ou est la toilette la plus proche?
> 
> I can guess what this means ;) But it would be better to formulate
> this in English.

        Where is the nearest watering hole, man?

is I guess quite good too.

> > + * B) the caller doesn't know the coordinates of the goal yet (but knows 
> 
> s/coordinates/map position/ also used on other places.

ok

> > +  enum direction8 dir_to_next_pos; /* Unsed only in struct_path */
> 
> It should be set to an invalid value otherwise.

Is
        #ifdef DEBUG 
ok with you?

> > +/* Iterates the map until it reaches (x, y).  Then fills the info
> > + * about it into pos.  Returns FALSE if position is unreachable.
> > + * Contents of pos in this case is not defined. */
> > +bool pf_get_position(struct pf_map *pf_map, int x, int y,
> > +                struct pf_position *pos);
> 
> We should write that it is a shortcut for 
> 
>   if(!pf_get_path(...)) return FALSE;
>   *pos = pf_last_position(path);

Okay, I will think about it.

> It looks like you forgot a pf_destroy_path function. I know why I
> prefer static allocation when it is possible.

Thinking about it, we should then change the signature to
        struct pf_path *pf_get_path(pf_map, x, y)
and let pf_get_path do all the allocations.

Is it okay with you?

G.