[Freeciv-Dev] Re: (PR#2370) Path finding

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Thu, Feb 27, 2003 at 01:51:34PM -0800, Gregory Berkolaiko wrote:

> + *      Ou est la toilette la plus proche?

I can guess what this means ;) But it would be better to formulate
this in English.

> + * B) the caller doesn't know the coordinates of the goal yet (but knows 

s/coordinates/map position/ also used on other places.

> +  enum direction8 dir_to_next_pos;   /* Unsed only in struct_path */

It should be set to an invalid value otherwise.

> +/* Iterates the map until it reaches (x, y).  Then fills the info
> + * about it into pos.  Returns FALSE if position is unreachable.
> + * Contents of pos in this case is not defined. */
> +bool pf_get_position(struct pf_map *pf_map, int x, int y,
> +                  struct pf_position *pos);

We should write that it is a shortcut for 

  if(!pf_get_path(...)) return FALSE;
  *pos = pf_last_position(path);

> +/* Return the full info on the position reached in the last call to 
> + * pf_next. */
> +void pf_next_get_position(const struct pf_map *pf_map,
> +                       struct pf_position *pos);

Same.

It looks like you forgot a pf_destroy_path function. I know why I
prefer static allocation when it is possible.

INITIAL_PATH_LENGTH is ugly. We should do a loop first to count and
then allocate.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "- Amiga Y2K fixes (a bit late, wouldn't you say?)"
    -- Linus Torvalds about linux 2.4.0 at 4 Jan 2001