Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2003:
[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
From: "Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>
Date: Wed, 26 Feb 2003 02:45:35 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Wed, Feb 26, 2003 at 02:36:08AM -0800, Jason Short wrote:
> Raimar Falke wrote:
> > On Wed, Feb 26, 2003 at 01:07:07AM -0800, Jason Short wrote:
> > 
> >>>It should make the normalization before. It the code wants to pass
> >>>non-real map positions in it has to use another macro.
> >>
> >>I have already proposed this, and you were against it also.  Yet some
> >>resolution is needed, and it should _not_ be to just say the caller has
> >>to write a local loop.
> > 
> > 
> > What about a mapview_square_iterate or unchecked_square_iterate?
> There is a second user for rectangle_iterate, which will not be helped 
> by either of these macros.  (Which is why I originally suggested 
> rectangle_iterate as the primary option, and only reported the 
> square_map_iterate bug in passing.)

What are the users of rectangle_iterate?

> Also, mapview_square_iterate is no good, since we're talking about the 
> map not the mapview here.

But only the mapview works with non-real map positions.

> unchecked_square_iterate seems way too overspecialized.

It describes the content. And it has a builtin warning sign ;)


 email: rf13@xxxxxxxxxxxxxxxxx
 "Sit, disk, sit. Good boy. Now spin up. Very good. Here's a netscape
  cookie for you. Fetch me some data. Come on, you can do it. No, not that
  data. Bad disk. Bad." 
    -- Calle Dybedahl, alt.sysadmin.recovery

[Prev in Thread] Current Thread [Next in Thread]