Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2003:
[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients:;
Subject: [Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 26 Feb 2003 02:36:08 -0800
Reply-to: rt@xxxxxxxxxxxxxx

Raimar Falke wrote:
> On Wed, Feb 26, 2003 at 01:07:07AM -0800, Jason Short wrote:
>>>It should make the normalization before. It the code wants to pass
>>>non-real map positions in it has to use another macro.
>>I have already proposed this, and you were against it also.  Yet some
>>resolution is needed, and it should _not_ be to just say the caller has
>>to write a local loop.
> What about a mapview_square_iterate or unchecked_square_iterate?

There is a second user for rectangle_iterate, which will not be helped 
by either of these macros.  (Which is why I originally suggested 
rectangle_iterate as the primary option, and only reported the 
square_map_iterate bug in passing.)

Also, mapview_square_iterate is no good, since we're talking about the 
map not the mapview here.  unchecked_square_iterate seems way too 


[Prev in Thread] Current Thread [Next in Thread]