[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Wed, Feb 26, 2003 at 02:28:17AM -0800, Per I. Mathisen wrote:
> On Wed, 26 Feb 2003, Raimar Falke wrote:
> > > > It should make the normalization before. It the code wants to pass
> > > > non-real map positions in it has to use another macro.
> > >
> > > I have already proposed this, and you were against it also.Yet some
> > > resolution is needed, and it should _not_ be to just say the caller has
> > > to write a local loop.
> > What about a mapview_square_iterate or unchecked_square_iterate?
> Writing a new iterator which is exactly like the square_iterate only that
> it doesn't have an assert is plain stupid. If the assert is that much of a
> bother, remove it. I'm with Ross and Jason on this one.
As I said before: I'm against weaking the macro just because one user
doesn't behave in the correct way.
Make a software that is foolproof, and only fools will want to use it.