Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2003:
[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
Home

[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
From: "Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>
Date: Mon, 24 Feb 2003 01:34:00 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, Feb 24, 2003 at 01:08:21AM -0800, Per I. Mathisen wrote:
> 
> On Mon, 24 Feb 2003, Raimar Falke wrote:
> > > > For some reason square_iterate calls CHECK_MAP_POS on its center tile.
> > > > This is a problem since it only shows up in debug mode and is not
> > > > obvious to the programmer.And I really don't know why it does that (I
> > > > wrote the code for it, some time ago).
> > > >
> > > > This CHECK_MAP_POS should probably be removed.
> > >
> > > And the patch.
> >
> > No. No. No. Just because one user has problemswith the check you
> > can't remove it and so punish the other users. Per fixed it in the
> > correct way in 3484 by fixing this one user.
> 
> Huh? Surely not in that patch.

You didn't remove the assert. Jason wants this in the square case.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  +#if defined(__alpha__) && defined(CONFIG_PCI)
  +       /*
  +        * The meaning of life, the universe, and everything. Plus
  +        * this makes the year come out right.
  +        */
  +       year -= 42;
  +#endif
    -- Patch for 1.3.2 (kernel/time.c) from Marcus Meissner




[Prev in Thread] Current Thread [Next in Thread]