[Freeciv-Dev] Re: Translation of log levels

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, May 11, 2002 at 06:32:33PM +0200, Christian Knoke wrote:
> Is it really usefull to translate log messages with loglevel > 2 ?
> (GAMELOG_*).

Do you mean freelog calls or gamelog calls? 

> AFAICS they are mostly for debugging and/or parsing with scripts, so
> they are more useful in english, no?

I agree for freelog calls. Offenders:
./client/audio.c:196:      freelog(LOG_VERBOSE, _("No sound file for tag %s 
(file %s)"), tag,
./common/shared.c:836:  freelog(LOG_VERBOSE, _("Could not find readable file 
\"%s\" in data path."),
./server/ruleset.c:118:  freelog(LOG_VERBOSE, _("Trying to load file from 
default ruleset directory "
./server/stdinhand.c:3049:        freelog(LOG_VERBOSE, _("Reduced maxplayers 
from %i to %i to fit "
./server/stdinhand.c:3061:        freelog(LOG_VERBOSE, _("Had to cut down the 
number of players to the "
./client/gui-gtk-2.0/gui_main.c:751:    freelog(LOG_DEBUG, _("Using fallback 
resources - which is OK"));
./server/mapgen.c:1104:  freelog(LOG_DEBUG, _("The map has %i starting 
positions on %i isles."),

Any objections if I remove the _() for these?

IMHO all gamelog calls should be translated (there are around 40).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 1 + 1 = 3, for large values of 1