[Freeciv-Dev] Re: [Patch] Add buy info

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Feb 16, 2002 at 01:22:56PM +0100, Christian Knoke wrote:
> On Fri, Feb 15, 2002 at 11:31:10PM -0600, Mike Kaufman wrote:
> > On Thu, Feb 14, 2002 at 06:43:56PM +0100, Raimar Falke wrote:
> > > 
> > > Attached is a patch which adds a buy info in the city dialog. It also
> > > disables the buy button.
> > 
> > I don't like this patch mainly because you can buy something just by
> > clicking too low and have no safeguard against it (It's also kinda ugly).
> > 
> > Attached is a patch which fixes those problems and reimplements the sell 
> > button 
> > as well.

The patch is also ok.

> Problem with Raimar's patch: you can't sell anything after
> you have bought something.

It looks like some error of me.

> 
> Problem with Mike's patch: Gold is not updated when I sell
> a building - neither in this or in another city.

> Besides this - to be honest - I'm not happy with both of them.
> There should be a popup which asks you whether you really want
> to buy / sell IMHO, like it is now. This is to have a safeguard
> and because the user expects it to work this way.
> 
> So these patches are about having the price for the unit / improvement
> displayed? What about this suggestion: Put the price there where
> the progess bar is now, i.e. remove the bar. I don't like this
> thing since long, because you neither can see clear the scrollbar
> nor the numbers at the same place. Then you can put it like this:
> 
> Musketeers
> 4/30  9 turns   price 85  [buy] [change]
> 
> Deactivate the buy button if you can't afford it and deactivate
> the change button if you've already bought this turn.
> This solution also gives more space for the improvements list.

Looks ok. How implements it?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "How about the new language C&? No, that's not 'c ampersand', 'c reference', 
  'reference to c' or 'c and'. It's pronounced 'campersand', to confuse the 
  hell out of people who are unfamiliar with it, and it will, of course, 
  have no pointers."
    -- Xazziri in comp.lang.c++ about C#