[Freeciv-Dev] Re: [PATCH] Improvement effects speedup (PR#1094)

[Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>]

On Tue, 15 Jan 2002, Ben Webb wrote:

> What you're suggesting is that I write the function as
> 
> void try_update_effects(int do_i_really_do_it)
> {
>   if (!do_i_really_do_it) return;
> 
>   /* main function body */
> }
> 
> and this seems rather nonsensical, particularly as you could apply the 
> same argument to _any_ function. What happens if the function returns a 
> value?

It isn't nonsensical because:

a) void update_all_effects(void)
   It doesn't return any arguments.

b) A non-insignificant amount of calls is in this fashion.
c) There are other functions in Freeciv that work like that.

But i don't care *that* much about it.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa