[Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 11:57 AM 01/12/31 +0000, Gregory Berkolaiko wrote:
> --- "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx> wrote: 
>> 
>> Subject:   Review of advdomestic.c9.dif
>> Submitter: Petr Baudis <pasky@xxxxxxxxxxx>
>> Date:      2001/12/29
>> Reviewer:  Ross Wetmore <rwetmore@xxxxxxxxxxxx>
>> 
>> Patched cleanly to CVS-Dec27. 
>> Compiles cleanly.
>> Runs. Before/after server savegames were different.
>> 
>> Most problems are tab/line length issues, but this *is* a style not 
>> substance patch, and it is important to get such things right. Couldn't
>> spot why the runtime behaviour changed in quick pass. Might be
>> hardcoded vs lookup values for some parameters with a private ruleset, 
>> but it is probably not that critical. 
>
>While we are talking about line wraps, I thought the accepted wrapping is
>before an operator, like
>
>if (doodle 
>    && beeble) {
>  blah = trrrrr
>         + frrrr;
>}
>
>and NOT
>if (doodle && 
>    beeble) {
>  blah = trrrrr + 
>         frrrr;
>}

I don't know if this was universally agreed on or agreed on by lack of 
response, but yes, yes, YES!
  indent -kr2 -bbo ...  # should be updated in the main FAQ pages.

>Yes, distinctly I remember (it was in the bleak November) this topic
>being discussed and an agreement being reached.  This is how it's done in
>tech literature anyways.

I'll take your word on it though :-).

>Best,
>G.
>__________________________________________________
>Do You Yahoo!?
>Everything you'll ever need on one web page
>from News and Sport to Email and Music Charts
>http://uk.my.yahoo.com