[Freeciv-Dev] advdomestic.c cleanup II. (PR#1157)

[Petr Baudis <pasky@xxxxxxxxxxx>]

Hello,

  attached patch cleans the main function for Domestic Advisor in AI.
Behaviour is not changed (autogames should remain same), it was only heavily
commented and variable names were expanded to something meaningful. Oh, yes,
and it seems to me that it compiles.

  Contrary to old version (reviewed by Ross and Raahul), this one makes
consistent changes in code (I hope), tries to use understandable english in
comments and explains some parts of code correctly :). Changes are just mainly
based on their suggestions (altough I've some debate with Ross about needful of
some changes ;).

  I think it's ready to actually go in, altough I'm open to objections and
ideas how to extend/correct it even more.

  Note that this patch is obviously only second in very long line. It modifies
smaller part of the code than the first one, but maybe some issues here will
be more controversial, who knows. Just let me know what do you think :).

  I skipped ai_build_eval() as I leave this one tasty piece to Ben and his
gen_impr patch, as it will change completely with it anyway.

Happy christmas hacking,

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
.
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/