[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
I'll pick it up and get a first review back sometime over the weekend, now
that I'm out of the topology maze :-).
Cheers,
RossW
=====
At 03:02 PM 01/12/28 -0600, Mike Kaufman wrote:
>On Mon, Dec 24, 2001 at 11:30:28AM +0100, Petr Baudis wrote:
>> Dear diary, on Mon, Dec 24, 2001 at 10:46:36AM CET, I got a letter,
>> where Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
>> > int want = pcity->ai.building_want[acity->currently_building];
>> > + /* Distance to wonder city was established after manage_bu and
before
>> > + * this. If we just started building a wonder during a_c_c_b, the
>> > + * started_building notify comes equipped with an update. It
calls
>> > + * generate_warmap, but this is a lot less warmap generation
than there
>> > + * would be otherwise. -- Syela */
>> > + int dist;
>> >
>> > I have no idea what this line
>> >
>> > If we just started building a wonder during a_c_c_b, the started_building
>> > notify comes equipped with an update.
>> >
>> > a_c_c_b baffles me. If you think this actually makes else, keep it.
>> Ok, I expanded the function names here :-).
>
>Could I get a couple of reviewers (and reviews) for this patch? Ross,
>Raahul?, anyone else?
>
>-mike
>
>
- [Freeciv-Dev] advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/23
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/23
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Raahul Kumar, 2001/12/24
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/24
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Mike Kaufman, 2001/12/28
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157),
Ross W. Wetmore <=
- [Freeciv-Dev] [Review] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/30
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Gregory Berkolaiko, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Raahul Kumar, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Mike Kaufman, 2001/12/31
|
|