[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

On Mon, Dec 31, 2001 at 08:57:49PM +0100, Petr Baudis wrote:
> Dear diary, on Mon, Dec 31, 2001 at 08:15:19PM CET, I got a letter, where 
> "Ross
> W. Wetmore" <rwetmore@xxxxxxxxxxxx> told me, that...
> > At 06:39 PM 01/12/31 +0100, Petr Baudis wrote:
> > >Dear diary, on Sun, Dec 30, 2001 at 07:49:49PM CET, I got a letter, where
> > >"Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx> told me, that...
> > [...]
> > >> +        build_points_left(acity) > get_unit_type(unit_type)->build_cost 
> > >> *
> > >> caravans) {
> > >> 
> > >> *** Another line wrap.
> > >Ok. Funny that people told me that I shouldn't do those changes I indent
> > >will care about them ;-).
> > 
> > Indent is not the saviour of the world, but only a useful starting point.
> > Once there is a basic pattern to the code, humans are infinitely more 
> > capable
> > of refining the pattern to highlight useful concepts.
> > 
> > I keep telling Raimar that blind application of indent to every patch just
> > before it goes in breaks code in many idiotic ways and removes useful added
> > value of the human touch.
> > 
> > Indent should be applied by a submitter, the code cleaned up to remove the
> > worst abuse of indent and to make sure it didn't actually change something
> > significant. Then changes can be applied consistent with the new (local)
> > coding standard of the code to be fixed. Patchew should then be applied
> > without additional (and certainly not mechanical) modification.
> This is basically my standpoint as well. Just in many projects the maintainer
> has the last word whether I like it or not and I must make yourself 
> comfortable
> with his opinion (and it's good as one opinion is still bettern than mix of
> dozen different opinions ;).

just for understanding, I disagree with Raimar on this particular point.
I do not and will not run patches through indent, although I agree with
most of the style guideline. A submitter should write his patch to
conform to the guideline, and if running the patch through indent helps
him to do that, then cool. He should just be prepared to fix any part of
his patch that indent mangles.

As a side note, can I get a thumbs up, thumbs down, on Petr's latest
revision. I've not looked at it yet, but if savegames are different, the
reason needs to be found. This is supposed to be _only_ a cleanup after
all.

-mike