Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2001:
[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
Home

[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Chris Richards <chrisr@xxxxxxxxxxxxxxxx>
Cc: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
From: Petr Baudis <pasky@xxxxxxxxxxx>
Date: Sat, 29 Dec 2001 18:51:42 +0100

Dear diary, on Sat, Dec 29, 2001 at 06:49:18PM CET, I got a letter, where Chris
Richards <chrisr@xxxxxxxxxxxxxxxx> told me, that...
> A general comment: get rid of the magic numbers and make them #define's.  In
> this patch, it seemed mainly to be the choice values that were offensive.
Where I notice them, I do this - however I didn't notice any here ;).

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv, (e)links
.
Firewall in a way is like the doorkeeper of a local pub. If you don't have your
I.D. on you, or if for some reason you do not qualify to enter, the doorkeeper
will not permit you to enter. In some extreme cases these doorkeepers will not
let you out, or at least give you a hard time before they finally let you out.
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/


[Prev in Thread] Current Thread [Next in Thread]