[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Mike Kaufman <mkaufman@xxxxxxxxxxxxxx> wrote:
> On Sun, Dec 30, 2001 at 02:49:14AM +0100, Petr Baudis wrote:
> > Dear diary, on Sun, Dec 30, 2001 at 02:46:01AM CET, I got a letter, where
> > Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
> > > It's those magic numbers less than 0, 199, and 200 that need explaining.
> I
> > > certainly don't know by reading the code what the hell 199 does. A
> > > descriptive name would help.
> > 199 is just 200 - 1, exactly as I said ;-) - when you want it in a
> different
> > way, maximal integer value under 200, which is magic bound I described
> about
> > five times already on the list and not going to do it once more ;-). It's
> used
> > for adjusting the desire under non-critical bound, so we won't <see
> comment> -
> > and this is then highest possible desire we can assign to it.
> 
> yes, yes, I agree with both of you. The numbers must be explained
> somewhere, but silly to comment on them everywhere they're used.
> 
> The obvious solution is to submit a patch for README.AI that outlines these
> sorts of issues. It sorely needs to be updated in any case. An explanation 
> of the above magic numbers and Ross's small primer recently posted would be 
> a good start.

OK. If Ross does not send in his primer in 3-4 days, I'll send it in after I
recover from New Years.

__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com