Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2001:
[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157) 		Home

[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Petr Baudis <pasky@xxxxxxxxxxx>
Cc: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
From: Chris Richards <chrisr@xxxxxxxxxxxxxxxx>
Date: 29 Dec 2001 11:49:18 -0600 
A general comment: get rid of the magic numbers and make them
#define's.  In this patch, it seemed mainly to be the choice values
that were offensive.

Cheers,
cjr
[Prev in Thread] Current Thread [Next in Thread]