[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Chris Richards <chrisr@xxxxxxxxxxxxxxxx> wrote:
> Bah.  If you used 395839325 in enough places it would be "so common"
> too... :)
> 
> But I'll acquiesce, nevertheless.
> 
> /cjr
> 
> Petr Baudis <pasky@xxxxxxxxxxx> writes:
> > Dear diary, on Sat, Dec 29, 2001 at 07:05:13PM CET, I got a letter, where
> Chris
> > Richards <chrisr@xxxxxxxxxxxxxxxx> told me, that...
> > > 100, 199, and 200 I think they were.
> > 199 is 200-1 - and these are so common that I think using
> > MAGICBOUNDBETWEENURGENTANDCRITICAL wouldn't make the code much better ;-) -
> and
> > they also aren't likely to change.
> > 
> > -- 

No don't give in. Fight the good fight. We will fight on the beaches, we will
fight on the .. er sorry. Actually, I think the numbers 0-100 make perfect
sense.
It's those magic numbers less than 0, 199, and 200 that need explaining. I
certainly don't know by reading the code what the hell 199 does. A descriptive
name would help.

__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com