[Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
At 04:37 PM 01/12/31 -0600, Mike Kaufman wrote:
>On Mon, Dec 31, 2001 at 08:57:49PM +0100, Petr Baudis wrote:
>As a side note, can I get a thumbs up, thumbs down, on Petr's latest
>revision. I've not looked at it yet, but if savegames are different, the
>reason needs to be found. This is supposed to be _only_ a cleanup after
>all.
I am happy (or at least have no reasonable objections) to anything in it.
I don't think the savegame issue is critical and personally don't see it
as a showstopper, but I wouldn't mind seeing it explained and/or removed.
BTW: I am sure I can force savegame differences by changing parameters in
the rulesets that were hardcoded constants in choice calculations and are
now changed to working references. It is the chance that some variable
rename screwed up that is more troubling.
I give it a thumbs up and will let others make the savegame call.
>-mike
Cheers,
RossW
=====
- [Freeciv-Dev] [Review] Re: advdomestic.c cleanup II. (PR#1157), (continued)
- [Freeciv-Dev] [Review] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/30
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Gregory Berkolaiko, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Raahul Kumar, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] Re: [Review] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Ross W. Wetmore, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Mike Kaufman, 2001/12/31
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157),
Ross W. Wetmore <=
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/31
- [Freeciv-Dev] flying AI, Gregory Berkolaiko, 2001/12/28
- [Freeciv-Dev] Re: flying AI, Reinier Post, 2001/12/28
- [Freeciv-Dev] Re: flying AI, Ross W. Wetmore, 2001/12/28
- [Freeciv-Dev] Re: flying AI, Petr Baudis, 2001/12/29
- [Freeciv-Dev] Re: flying AI, Chris Richards, 2001/12/29
- Message not available
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/29
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Chris Richards, 2001/12/29
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Petr Baudis, 2001/12/29
- [Freeciv-Dev] Re: advdomestic.c cleanup II. (PR#1157), Chris Richards, 2001/12/29
|
|