Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: [PATCH] Re: AI questions

[Freeciv-Dev] Re: [PATCH] Re: AI questions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Petr Baudis <pasky@xxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] Re: AI questions
From: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>
Date: Sat, 24 Nov 2001 20:46:53 +0000 (GMT)

 --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
[.. discussion about ai_manage_explorer ..]

> Do we need to re-generate warmap in part three? I would remove it, as
> it looks
> only as wasting CPU time for me, the map shouldn't change while
> executing
> that function. What do you think?

I think that the map doesn't change but your location might.
And if you are in the same location then the warmap is cached.

> Patch is attached. Ok, I reformat one small part of one condition

>    x = punit->x; y = punit->y;
> -  if (is_ground_unit(punit)) con = map_get_continent(x, y);
> -  else con = 0; /* Thanks, Tony */
> +  if (is_ground_unit(punit)) continent = map_get_continent(x, y);
> +  else continent = 0; /* ships don't care about continents */
I am not sure this comment is correct

> +      /* We won't travel to another continents or into foreign

"another continent" or "other continents"

All in all there is nothing particulary great about the patch but it is a
step in the right direction (provided Raimar is satisfied with


Do You Yahoo!?
Everything you'll ever need on one web page from News and Sport to Email and 
Music Charts

[Prev in Thread] Current Thread [Next in Thread]