[Freeciv-Dev] [PATCH2] Re: AI questions

[Petr Baudis <pasky@xxxxxxxxxxx>]

> > > > Also it looks we can try to sell palace when we need money (we only
> > > > won't sell city walls), which may lead to big problems (as mentioned in
> > > > another thread ;-). Maybe we shouldn't try to sell anything with upkeep
> > > > 0, as it won't drain us anyway and we can get into problems w/o it, as
> > > > it is usually something special.
> > > 
> > > This is harder than it looks. Adam Smith matters, barracks matter etc.
> > Yeah, true. So let's check it against original value from ruleset.
> > 
> > > > Selling palace doesn't threaten in ai_sell_obsolete_unit(), however i
> > > > would modify that too, as we can keep obsolete buildings there, if they
> > > > don't cost us anything, because who knows, wonder which obsoletes them
> > > > may get obsoleted etc..
> > > 
> > > No I don't think so. Any building which is obsoleted by a wonder, is
> > > never built again. City walls are an exception, but they are not
> > > obsoleted by the Great Wall.
> > Yes, but they are taken as 'duplicate', de-facto obsoleted, even if you
> > still can build them. This would make that more universal, and even save
> > few cpu cycles not vainly trying to sell wonders.
> 
> Do we try to sell wonders currently? I strongly suspect you are wrong on this
> point.
> 
> > default ruleset dependent, and this would help it.
> > 
> > > What obsolete buildings cost us nothing? Only improvs that get obsoleted
> > > are barracks. Barracks always cost us something, and until we get the
> > > last bunch of barracks, they can always be obsoleted.
> > I took City walls as obsoleted by Great wall, ok, they aren't. However they
> > frequently acts in such a way.
> >
> 
> Up to you. You're the one implementing it, I'm just the gallery.
So here it goes, splitted into two separate patches. First one improves
formatting, second one changes testing for B_CITY by testing for zero upkeep in
ruleset.

Also, I'm including corrected version of explorer patch, grep betrayed me and
didn't show tokens in server/unit(hand|tools).c - I really hope i will
*finally* start posting correct patches :|.

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC
Real Users hate Real Programmers.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/

aicleanup-selling.diff
Description: Text document

ai-dontsellupkeep0.diff
Description: Text document

aicleanup-exploring.diff
Description: Text document