[Freeciv-Dev] Re: new_city_dialog ver 12

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-10-23 17:39:33, Raimar Falke wrote:
> On Tue, Oct 23, 2001 at 02:40:51PM +0200, Daniel Sjölie wrote:
> > On 2001-10-23 12:49:32, Raimar Falke wrote:
> > > The "City Info" and the "City Map" frame shouldn't enlarge if the
> > > window is enlarged.
> > 
> > I'm not sure about this... I think it looks very ok...
> 
> I think it is ugly.

I don't... But it's not a big enough issue to fight about now, right?
You can change this yourself later if people agree with you...

> > > "No trade routes exists" isn't centered.
> > 
> > Hmm... It seems centered to me...
> > Screenshot?
> 
> But not between the top and bottom.

Right... It actually is but there's some newlines above it... :)
That's left from when trade routes were on the overview page...
It's fixed...

> > > You may add the buy information I still would found nice.
> > 
> > Yes, it might take some effort to make right though...
> > I probably won't have the time to do this soon and I'd like to see the
> > patch finished soon... It's a feature that could be added later of
> > course...
> 
> If I provide a patch?

If you can do it in a good way, sure... But I'd prefer if you did this
later since I think it's not trivial to get everyone to agree on what is
a good way (since it's kinda crowded there now)

> > > If the city dialog is already open for a city and the user press
> > > "popup" the second time in the city list dialog the existing dialog
> > > should come to the front.
> > 
> > Mmm... Perhaps... What should happen in the dialog you were in?
> 
> Just bring the already open dialog to front.
> 
> > If it always should do that you would be forced to close the other
> > dialog to step on... Also I'm not sure there is a really good and
> > standard way to bring a window to the front...
> 
> gdk_window_raise.

I see the advantage here but I also see the disadvantage...
If you want to cycle through cities and you get to one that's allready
open you have to close it to go on... You might not want to do that...
Solving this problem is not trivial I think... It can wait...

> $ grep indent freeciv_hackers_guide.txt
> - Use K&R indentation style with indentation 2 (when in doubt, use
>   "indent -kr -i2").  However, do not re-indent areas of code you are

Done...
Mike: If you do this aswell my patch should apply to your tree, right?

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)