[Freeciv-Dev] Re: new_city_dialog ver 12

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 23, 2001 at 02:40:51PM +0200, Daniel Sjölie wrote:
> On 2001-10-23 12:49:32, Raimar Falke wrote:
> > The "City Info" and the "City Map" frame shouldn't enlarge if the
> > window is enlarged.
> 
> I'm not sure about this... I think it looks very ok...

I think it is ugly.

> > "Sentry units" should be "Sentry all units".
> 
> Hmm... Or really "Sentry all present units"...
> Hmm... Lets be consistent and make change all the buttons to
> "Activate present units", "Sentry present units" and "List present
> units" - ok?

Yes.

> > The wrapping of the happiness texts are still wrapped at the wrong
> > width. You may want to use a fixed layout.
> 
> Perhaps, but maybe that can wait? I think it can be added as is then
> someone who thinks that's really ugly (I don't really) can fix it
> later...

IMHO it shouldn't be hard to disable the wrapping in the GTK widget
and insert \ns by hand.

> > "No trade routes exists" isn't centered.
> 
> Hmm... It seems centered to me...
> Screenshot?

But not between the top and bottom.

> > I'm I correct that the tooltips are used in only one place? For
> > example you may provide tooltips for the units, which show the type,
> > hp, homecity, movements left.
> 
> Yes, and in tons of other places in the game... :)
> Actually, with your suggestion of growth info on a seperate row I don't
> think we need any tooltips at all... I'd rather consider covering the
> game in tooltips a seperate project from this city dialog... :)

Ok, then remove it and have the patch which inserts the tooltip code
handy.

> > You may add the buy information I still would found nice.
> 
> Yes, it might take some effort to make right though...
> I probably won't have the time to do this soon and I'd like to see the
> patch finished soon... It's a feature that could be added later of
> course...

If I provide a patch?

> > If the city dialog is already open for a city and the user press
> > "popup" the second time in the city list dialog the existing dialog
> > should come to the front.
> 
> Mmm... Perhaps... What should happen in the dialog you were in?

Just bring the already open dialog to front.

> If it always should do that you would be forced to close the other
> dialog to step on... Also I'm not sure there is a really good and
> standard way to bring a window to the front...

gdk_window_raise.

> I don't think it's worth the hassel... Not now anyway...

> > If the misc. settings pane: if the window is enlarged the tooltip and
> > next-time-open frame should enlarge.
                               insert "n't"

> Umm... It does for me...
> What gtk version are you using?


> > 0-vs-FALSE and 1-vs-TRUE. This isn't your fault but it something which
> > I have noticed.
> 
> Ok... Perhaps that can be changed later if desired? To not confuse this
> patch any more with unrelated changes... :)

Yes.

> > Can you tell what kind of change you have done to gtk_accelbutton_new?
> 
> It didn't work before... The one in cvs still doesn't work for me...
> Perhaps it's a gtk version problem but this implementation should be
> safer...

Very odd.

> > +#define WORKLIST_ADVANCED_TARGETS      1
> > +#define WORKLIST_CURRENT_TARGETS       0
> > +#define COLUMNS                                4
> > +#define BUFFER_SIZE                    100
> > +#define NUM_TARGET_TYPES               3
> > 
> > Please adjust the COLUMNS line. You can run indent over
> > {happiness,citydlg,wldlg}.[ch].
> 
> With what arguments?

$ grep indent freeciv_hackers_guide.txt
- Use K&R indentation style with indentation 2 (when in doubt, use
  "indent -kr -i2").  However, do not re-indent areas of code you are

        Raimar
-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Two OS engineers facing a petri net chart:
        "dead lock in four moves!"