Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: find_the_shortest_path()
Home

[Freeciv-Dev] Re: find_the_shortest_path()

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Cc: jdorje@xxxxxxxxxxxxxxxxxxxxx, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: find_the_shortest_path()
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 19 Sep 2001 09:29:50 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Tue, Sep 18, 2001 at 07:54:57PM -0400, Ross W. Wetmore wrote:
> Removing dir_ok doesn't sound like a high priortiy task. If it is
> trivial then do it in passing some time.
> 
> There may not be much point in fixing straightest direction with
> scalar product. The time here would be better spent understanding
> the correct patch and/or applying the patch you already have.
> 
> MAPSTEP itself is trivial to add as a macro. The time here is 
> locating the places in the code where it can be used. 

> This is better done after the cleanups have standardized the code
> and all flavours of map_adjust are converted to normalize_map_pos.

Is there any patch out which I have missed?

> And there is no real value here except as part of the cleanup.

Ack.

> You can pick these up the next time I drop the target version of 
> all this into incoming, and apply whatever parts you want to pick
> and choose from to CVS. I warn you the diff is nearing 500Kb by
> now. And there are still a lot of bugfixes you didn't take in the
> earlier version not to mention cleanups.

I hope that you have splitted it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  +#if defined(__alpha__) && defined(CONFIG_PCI)
  +       /*
  +        * The meaning of life, the universe, and everything. Plus
  +        * this makes the year come out right.
  +        */
  +       year -= 42;
  +#endif
    -- Patch for 1.3.2 (kernel/time.c) from Marcus Meissner


[Prev in Thread] Current Thread [Next in Thread]