[Freeciv-Dev] Re: find_the_shortest_path()

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

Removing dir_ok doesn't sound like a high priortiy task. If it is
trivial then do it in passing some time.

There may not be much point in fixing straightest direction with
scalar product. The time here would be better spent understanding
the correct patch and/or applying the patch you already have.

MAPSTEP itself is trivial to add as a macro. The time here is 
locating the places in the code where it can be used. This is 
better done after the cleanups have standardized the code and
all flavours of map_adjust are converted to normalize_map_pos.
And there is no real value here except as part of the cleanup.

You can pick these up the next time I drop the target version of 
all this into incoming, and apply whatever parts you want to pick
and choose from to CVS. I warn you the diff is nearing 500Kb by
now. And there are still a lot of bugfixes you didn't take in the
earlier version not to mention cleanups.

So most of these patch tasks go away, if you want to spend time
on more worthwhile stuff.

Cheers,
RossW
=====

At 11:43 AM 01/09/18 +0200, Raimar Falke wrote:
>On Tue, Sep 18, 2001 at 04:37:11AM -0400, Jason Dorje Short wrote:
[...]
>Looks ok. However I have to verify this. And there are other patch
>already in the queue (your cleanup patch, remove dir_ok,
>straightest_direction with scalar product, the trireme patch, the two
>city report dialog patches and making a MAPSTEP patch if nobody turns
>up) and in addition to this I hope to finally get a polished version
>of the CMA out of the door. So please go further to clean up the goto
>handling.
>
>       Raimar
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "> WHY?! Isn't it better to put $(shell cat cscope.files) on the list of
>  I only have a yellow belt in makefile kungfu.  These fancy gnu make things
>  are relatively new to some of us..."
>    -- Mark Frazer to Vassilii Khachaturov in linux-kernel