[Freeciv-Dev] Re: new player dialog

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 23, 2001 at 02:23:24PM +0200, Erik Sigra wrote:
> torsdagen den 23 augusti 2001 14:09 skrev Reinier Post:
> > On Thu, Aug 23, 2001 at 01:43:42PM +0200, Karl-Ingo Friese wrote:
> > > Could you please check if the problem only occurs in the new
> > > players report? Because as Raimar described it it seems to be
> > > a generell problem of the german translation - and not of the
> > > dialog itself.
> >
> > But the length of strings in translated dialogs is a hard problem.
> > How hard would it be to have an option on dialogs to automatically
> > shorten the string (replacing the characters in the middle with ...)
> > when they grow beyond a maximum size?
> 
> The real problem is not that there are a few long strings in some 
> localizations. The real problem is that GTK magnifies this a lot by making 
> all buttons long. So the solution is not to ... but to teach GTK some manners.

Good point. At least for the current player dialog
Index: plrdlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/plrdlg.c,v
retrieving revision 1.21
diff -u -r1.21 plrdlg.c
--- plrdlg.c    2001/01/29 18:55:30     1.21
+++ plrdlg.c    2001/08/23 12:46:48
@@ -110,6 +110,11 @@
   if (!titles) titles = intl_slist(NUM_COLOUMS, titles_);
 
   players_dialog_shell = gtk_dialog_new();
+
+  gtk_box_set_homogeneous(GTK_BOX
+                         (GTK_DIALOG(players_dialog_shell)->action_area),
+                         0);
+
   gtk_signal_connect( GTK_OBJECT(players_dialog_shell),"delete_event",
         GTK_SIGNAL_FUNC(players_button_callback),NULL );
   gtk_accel_group_attach(accel, GTK_OBJECT(players_dialog_shell));

helps. Does anybody sees a problem with this?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  What's nice about GUI is that you see what you manipulate.
  What's bad about GUI is that you can only manipulate what you see.