Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: new player dialog
Home

[Freeciv-Dev] Re: new player dialog

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Karl-Ingo Friese <kif@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: new player dialog
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 23 Aug 2001 17:03:11 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Thu, Aug 23, 2001 at 04:58:39PM +0200, Karl-Ingo Friese wrote:
> On Thu, 23 Aug 2001, Raimar Falke wrote:
> 
> > On Thu, Aug 23, 2001 at 01:14:08PM +0200, Karl-Ingo Friese wrote:
> >
> > Ok checking the flags isn't your job. Just bail out. I still think it
> > doesn't happen and you just programmed very defensive.
> 
> Hmm, I think we are still misunderstanding each other. I need to find
> out the real flag dimensions. All flags are stored in pixmaps of the
> same width. But the dimensions of the flags (the rectangular area
> of pixels in which the flag can be found and which is not masked out)
> differs from flag to flag. So I need to calculate the flags pixmaps
> in either case.

I understood this.

> The defensive part is jus that I check the real flag dimensions do not
> get to small. You are right. I can remove that.

Leave the check in but make it fatal (i.e. an assert instead of using
the whole size).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 1 + 1 = 3, for large values of 1


[Prev in Thread] Current Thread [Next in Thread]