[Freeciv-Dev] Re: new player dialog

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Aug 22, 2001 at 09:19:30PM +0200, Karl-Ingo Friese wrote:
> Attached is the new plrdrlg.c from client/gui-gtk.
> 
> New features in short:
> 
> o sortable columns (name, nation, status, ...)
> o colors for allies / enemies
> o includes the flag pixmaps
> 
> Commets, improvements or suggestions will be welcome ;-)

> -#define NUM_COLOUMS 9
> +#define NUM_COLUMS 11

??

> +void build_flag(int playerindex) {

Lets try to understand this:
 - you remove the black border
 - scale it
 - add the border?
Correct?

> +  while (gdk_image_get_pixel(mask_image, flag_w-1, 0)==0 && flag_w>4) 
> flag_w--;
> +  if (flag_w<5) flag_w=flag_sprite->width;

What is the reason for these constructs?

Another point: the dialog is more than 1024 pixel wide. And I can't
decrease the width.

Overall it looks good.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"