Re: [Freeciv-Dev] cranky mode mail

[Daniel Sjolie <deepone@xxxxxxxxxx>]

On 1999-06-02 11:24:06, David Pfitzner wrote:
> (Except the if(0) stuff for debug messages I would defend: it 
> makes it easy to toggle individual messages on/off in the code, 
> and the if()'s should optimise away when compiled.  But in any
> case there is a patch which will make this unnecessary.)

Aha!
It's to toggle _individual_ massages... :)
If You have that many messages that You can't group them into groups
that You can switch on of with descriptive macros You have too many... :)
(for ex if (DBGMSG_MAIN) yadda_yadda();   )

> > Linux kernel coding style:
> 
> > 'Chapter 1: Indentation
> 
> What _I_ would prefer is for people to use the "freeciv style"
> of indentation, even if they don't personally prefer it (even
> though _I_ don't personally prefer it) (and even if it 
> does not match the "linux kernel coding style" ;-)

Well, that would be all ok if I wasn't so certain I was rigt! :)
Hehehe...

> Otherwise we get an ugly mix of all sorts of different indentation
> styles spread through the code.
> 
> (People have suggested doing a big re-indent of the whole code 
> sometime, but I don't really think thats necessary.  It would make
> it harder to use old diffs, and harder to use CVS to compare vs 
> older versions.  But maybe.)

I'm for it! :)

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)